Bug 21132 - Highlight active filters on saved report page
Summary: Highlight active filters on saved report page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-30 17:32 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the search term highlighting (31.38 KB, image/png)
2018-07-30 17:32 UTC, Owen Leonard
Details
Bug 21132: Highlight active filters on saved report page (4.55 KB, patch)
2018-07-30 17:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21132: Highlight active filters on saved report page (4.57 KB, patch)
2018-08-03 18:19 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 21132: Highlight active filters on saved report page (4.65 KB, patch)
2018-08-06 17:25 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-07-30 17:32:52 UTC
Created attachment 77325 [details]
Screenshot showing the search term highlighting

I propose to add a more obvious view of which terms have been submitted to filter the saved reports page.
Comment 1 Owen Leonard 2018-07-30 17:39:31 UTC
Created attachment 77326 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.
Comment 2 Maryse Simard 2018-08-03 18:19:18 UTC
Created attachment 77482 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.
Comment 3 Jonathan Druart 2018-08-06 17:25:43 UTC
Created attachment 77495 [details] [review]
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-08-09 12:38:00 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-10 08:16:49 UTC
Enhancement, will not backport to 18.05.x series.