Bug 21381

Summary: Add serial enumeration to circulation history
Product: Koha Reporter: Michal Denar <black23>
Component: CirculationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: black23, caroline.cyr-la-rose, david, gmcharlt, josef.moravec, kyle.m.hall, lucas, martin.renvoize, rbit
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/678 https://gitlab.com/koha-community/koha-manual/-/merge_requests/605
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on:    
Bug Blocks: 18080    
Attachments: Bug 21381: Add serial enumeration to circulation/checkout history
Bug 21381: (follow-up) Fix table configuration for new column
Screenshot of table settings - column name label is blank
Bug 21381: (follow-up) fix typo in columns setting yml
Bug 21381: Add serial enumeration to circulation/checkout history
Bug 21381: (follow-up) Fix table configuration for new column
Bug 21381: (follow-up) fix typo in columns setting yml
Bug 21381: Add serial enumeration to circulation/checkout history
Bug 21381: (follow-up) Fix table configuration for new column
Bug 21381: (follow-up) fix typo in columns setting yml
Bug 21381: (QA follow-up) Add missing filter

Description Michal Denar 2018-09-19 12:37:14 UTC
If librarian lookig for specific item (periodical), on circulation history absent info about serial enumeration / chronology
Comment 1 Katrin Fischer 2022-10-17 21:44:53 UTC
Created attachment 142033 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

https://bugs.koha-community.org/show_bug.cgi?id=31281
Comment 2 Katrin Fischer 2022-10-17 21:45:21 UTC
This should get us started here :)
Comment 3 Katrin Fischer 2022-10-17 22:20:56 UTC
Created attachment 142035 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.
Comment 4 David Nind 2022-10-18 18:42:51 UTC
Created attachment 142087 [details]
Screenshot of table settings - column name label is blank

Hi Katrin.

This all works, however for me the column name in the table settings is blank (see screenshot).

Also, should this be an option on the checkout history page for a record's details page?

David
Comment 5 Lucas Gass 2022-10-24 21:39:31 UTC
Created attachment 142573 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml
Comment 6 David Nind 2022-10-24 23:04:00 UTC
Created attachment 142582 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

https://bugs.koha-community.org/show_bug.cgi?id=31281

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-10-24 23:04:06 UTC
Created attachment 142583 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2022-10-24 23:04:11 UTC
Created attachment 142584 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Martin Renvoize 2022-11-02 14:12:50 UTC
Created attachment 142980 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2022-11-02 14:12:55 UTC
Created attachment 142981 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize 2022-11-02 14:13:00 UTC
Created attachment 142982 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize 2022-11-02 14:13:05 UTC
Created attachment 142983 [details] [review]
Bug 21381: (QA follow-up) Add missing filter

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize 2022-11-02 14:13:34 UTC
Nice little addition, no regressions..

Passing QA
Comment 14 Tomás Cohen Arazi 2022-11-04 22:14:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!