Bug 21381 - Add serial enumeration to circulation history
Summary: Add serial enumeration to circulation history
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Katrin Fischer
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 18080
  Show dependency treegraph
 
Reported: 2018-09-19 12:37 UTC by Michal Denar
Modified: 2023-12-28 20:42 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/678 https://gitlab.com/koha-community/koha-manual/-/merge_requests/605
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 21381: Add serial enumeration to circulation/checkout history (3.66 KB, patch)
2022-10-17 21:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21381: (follow-up) Fix table configuration for new column (973 bytes, patch)
2022-10-17 22:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Screenshot of table settings - column name label is blank (45.09 KB, image/png)
2022-10-18 18:42 UTC, David Nind
Details
Bug 21381: (follow-up) fix typo in columns setting yml (734 bytes, patch)
2022-10-24 21:39 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 21381: Add serial enumeration to circulation/checkout history (3.70 KB, patch)
2022-10-24 23:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 21381: (follow-up) Fix table configuration for new column (1022 bytes, patch)
2022-10-24 23:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 21381: (follow-up) fix typo in columns setting yml (782 bytes, patch)
2022-10-24 23:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 21381: Add serial enumeration to circulation/checkout history (3.71 KB, patch)
2022-11-02 14:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 21381: (follow-up) Fix table configuration for new column (1.06 KB, patch)
2022-11-02 14:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 21381: (follow-up) fix typo in columns setting yml (847 bytes, patch)
2022-11-02 14:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 21381: (QA follow-up) Add missing filter (1.27 KB, patch)
2022-11-02 14:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Denar 2018-09-19 12:37:14 UTC
If librarian lookig for specific item (periodical), on circulation history absent info about serial enumeration / chronology
Comment 1 Katrin Fischer 2022-10-17 21:44:53 UTC
Created attachment 142033 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

https://bugs.koha-community.org/show_bug.cgi?id=31281
Comment 2 Katrin Fischer 2022-10-17 21:45:21 UTC
This should get us started here :)
Comment 3 Katrin Fischer 2022-10-17 22:20:56 UTC
Created attachment 142035 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.
Comment 4 David Nind 2022-10-18 18:42:51 UTC
Created attachment 142087 [details]
Screenshot of table settings - column name label is blank

Hi Katrin.

This all works, however for me the column name in the table settings is blank (see screenshot).

Also, should this be an option on the checkout history page for a record's details page?

David
Comment 5 Lucas Gass (lukeg) 2022-10-24 21:39:31 UTC
Created attachment 142573 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml
Comment 6 David Nind 2022-10-24 23:04:00 UTC
Created attachment 142582 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

https://bugs.koha-community.org/show_bug.cgi?id=31281

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-10-24 23:04:06 UTC
Created attachment 142583 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2022-10-24 23:04:11 UTC
Created attachment 142584 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Martin Renvoize (ashimema) 2022-11-02 14:12:50 UTC
Created attachment 142980 [details] [review]
Bug 21381: Add serial enumeration to circulation/checkout history

* Set readinghistory and intranetreadinghistory to Allow
* Check out some items and return some.
  At least one item should have serial enumeration set to something
* Go to OPAC > patron account > checkout history
* Verify the Vol info shows the same as on the detail page.
* Go to staff interface > patron account > circulation history
* Verify the Vol info shows correctly there as well.
  Bug 21381: Add serial enumeration to circulation/checkout history

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize (ashimema) 2022-11-02 14:12:55 UTC
Created attachment 142981 [details] [review]
Bug 21381: (follow-up) Fix table configuration for new column

The new column was added to the table settings configuration.

To test:
* Make sure the column shows up in the columns menu of the table
  in the staff interface.
* Verify it can be hidden/unhidden correctly using the menu
  or the table setings.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize (ashimema) 2022-11-02 14:13:00 UTC
Created attachment 142982 [details] [review]
Bug 21381: (follow-up) fix typo in columns setting yml

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2022-11-02 14:13:05 UTC
Created attachment 142983 [details] [review]
Bug 21381: (QA follow-up) Add missing filter

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize (ashimema) 2022-11-02 14:13:34 UTC
Nice little addition, no regressions..

Passing QA
Comment 14 Tomás Cohen Arazi (tcohen) 2022-11-04 22:14:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!