Summary: | Search bar on Stock rotation page displays both [-] and [+] simultaneously | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 11897 | ||
Bug Blocks: | |||
Attachments: |
Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously
Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously |
Description
Caroline Cyr La Rose
2018-10-19 02:09:09 UTC
I'm not sure what is the decision process to choose which search bar to put at the top of a page, but I feel like "Search patrons" is not useful in this case. I would put the same search bar as in "Rotation collections" with Check out, Check in, Renew and Search the catalog, the latter being selected by default. Created attachment 80931 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the circulation search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' Owen, can you select "Search the catalog" by default, instead of "Check out"? Created attachment 80987 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Created attachment 80991 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 81026 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Dependency not in 18.05.x series. |