When I go to the stock rotation page, the search bar at the top of the page is set to "Search patrons" and both [-] and [+] are displayed. To reproduce: 1) Activate stock rotation module in system preferences 2) Go to Tools > Stock rotation 3) Notice the [-] and [+] next to the search bar at the top 4) Try clicking on [-] and [+], nothing happens
I'm not sure what is the decision process to choose which search bar to put at the top of a page, but I feel like "Search patrons" is not useful in this case. I would put the same search bar as in "Rotation collections" with Check out, Check in, Renew and Search the catalog, the latter being selected by default.
Created attachment 80931 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the circulation search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.'
Owen, can you select "Search the catalog" by default, instead of "Check out"?
Created attachment 80987 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected.
Created attachment 80991 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 81026 [details] [review] Bug 21614: Search bar on Stock rotation page displays both [-] and [+] simultaneously This patch modifies the stock rotation template so that it include the catalog search bar include instead of the patrons one. To test, apply the patch and enable the StockRotation system preference. - Go to Tools -> Stock rotation. - Confirm that the search boxes at top are 'Check out,' 'Check in,' 'Renew,' and 'Search the catalog.' 'Search the catalog' should be selected. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Dependency not in 18.05.x series.