Bug 21663

Summary: Incorrect filter prevents predefined notes from being added to patron acccounts
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: jonathan.druart, josef.moravec, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 13618    
Bug Blocks: 21669    
Attachments: Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts
Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API

Description Owen Leonard 2018-10-25 13:22:51 UTC
When viewing a patron-related page in the staff client one should be able to click the "Add message" button in the toolbar and select notes which have been defined in authorised_values category BOR_NOTES. In incorrect html filter at line 112 of members-toolbar.inc breaks this functionality.
Comment 1 Owen Leonard 2018-10-25 13:33:54 UTC
Created attachment 81162 [details] [review]
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts

This patch removes an "html" filter from the template include which
allows one to add predefined nots to a patron's account.

To test, apply the patch and open a patron record for viewing or
checkout. Click the "Add message" button. The "predefined notes"
dropdown should contain the authorised_values you have with the
'BOR_NOTES' category.
Comment 2 Andrew Isherwood 2018-10-25 15:04:30 UTC
Created attachment 81172 [details] [review]
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts

This patch removes an "html" filter from the template include which
allows one to add predefined nots to a patron's account.

To test, apply the patch and open a patron record for viewing or
checkout. Click the "Add message" button. The "predefined notes"
dropdown should contain the authorised_values you have with the
'BOR_NOTES' category.

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Comment 3 Jonathan Druart 2018-10-25 15:25:17 UTC
Created attachment 81180 [details] [review]
Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts

This patch removes an "html" filter from the template include which
allows one to add predefined nots to a patron's account.

To test, apply the patch and open a patron record for viewing or
checkout. Click the "Add message" button. The "predefined notes"
dropdown should contain the authorised_values you have with the
'BOR_NOTES' category.

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-10-26 17:25:05 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-06 11:57:08 UTC
Bug not present in 18.05.x series.
Comment 6 Josef Moravec 2019-04-01 12:13:15 UTC
Created attachment 87275 [details] [review]
Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API

Test plan:
1) Apply the patch
2) Restart plack
3) Access GET to /patrons/{patron_id}/checkouts
It should have the same abilities as /checkouts?patron_id={patron_id}
4) prove t/db_dependent/api/v1/checkouts.t
Comment 7 Josef Moravec 2019-04-01 12:28:05 UTC
Comment on attachment 87275 [details] [review]
Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API

Sorry, wrong bug number