When viewing a patron-related page in the staff client one should be able to click the "Add message" button in the toolbar and select notes which have been defined in authorised_values category BOR_NOTES. In incorrect html filter at line 112 of members-toolbar.inc breaks this functionality.
Created attachment 81162 [details] [review] Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category.
Created attachment 81172 [details] [review] Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 81180 [details] [review] Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts This patch removes an "html" filter from the template include which allows one to add predefined nots to a patron's account. To test, apply the patch and open a patron record for viewing or checkout. Click the "Add message" button. The "predefined notes" dropdown should contain the authorised_values you have with the 'BOR_NOTES' category. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Bug not present in 18.05.x series.
Created attachment 87275 [details] [review] Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Test plan: 1) Apply the patch 2) Restart plack 3) Access GET to /patrons/{patron_id}/checkouts It should have the same abilities as /checkouts?patron_id={patron_id} 4) prove t/db_dependent/api/v1/checkouts.t
Comment on attachment 87275 [details] [review] Bug 21663: Add /patrons/{patron_id}/checkouts endpoint to REST API Sorry, wrong bug number