Description
Tomás Cohen Arazi
2018-12-26 16:30:28 UTC
Created attachment 83501 [details] [review] Bug 22048: Use set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. Created attachment 83502 [details] [review] Bug 22048: Use set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual Created attachment 83503 [details] [review] Bug 22048: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, Created attachment 83504 [details] [review] Bug 22048: Use set_password in create_superlibrarian.pl Use $patron->set_password instead of update_password. In this case the 'skip_validation' param needs to be set as no password strength checks are expected. Created attachment 83505 [details] [review] Bug 22048: Use set_password opac/opac-password-recovery.pl Created attachment 83506 [details] [review] Bug 22048: Use set_password in tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Search/History.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t => SUCCESS: Tests pass! - Sign off :-D Created attachment 83507 [details] [review] Bug 22048: Use set_password in Auth_with_ldap.pm Created attachment 83585 [details] [review] Bug 22048: Use set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83586 [details] [review] Bug 22048: Use set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83587 [details] [review] Bug 22048: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83588 [details] [review] Bug 22048: Use set_password in create_superlibrarian.pl Use $patron->set_password instead of update_password. In this case the 'skip_validation' param needs to be set as no password strength checks are expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83589 [details] [review] Bug 22048: Use set_password opac/opac-password-recovery.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83590 [details] [review] Bug 22048: Use set_password in tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Search/History.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83591 [details] [review] Bug 22048: Use set_password in Auth_with_ldap.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83597 [details] [review] Bug 22048: Use set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83598 [details] [review] Bug 22048: Use set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83599 [details] [review] Bug 22048: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83600 [details] [review] Bug 22048: Use set_password in create_superlibrarian.pl Use $patron->set_password instead of update_password. In this case the 'skip_validation' param needs to be set as no password strength checks are expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83601 [details] [review] Bug 22048: Use set_password opac/opac-password-recovery.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83602 [details] [review] Bug 22048: Use set_password in tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Search/History.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83603 [details] [review] Bug 22048: Use set_password in Auth_with_ldap.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported at this time to 18.11.x series. |