Trying to reset a password using the forgotten password OPAC functionality seems to fail with one of a couple of messages: Can't call method "catch" without a package or object reference at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 158 or Can't call method "isa" on an undefined value at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 159 This seems to happen after commit f822dee088b86edecd5d5c73718ad9f8a04c0664 To reproduce: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail.
Created attachment 86854 [details] [review] Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch, restart the things Go through the process again, password should be reset.
Created attachment 86857 [details] [review] Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 86859 [details] [review] Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome work all! Pushed to master for 19.05
The enhancement that caused this was not backported to 18.11.x series.