Summary: | Hide default value fields by default on patron import | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, george, lucas, maryse.simard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
Attachments: |
Bug 23385: Hide 'Default values' fields by default
Bug 23385: Hide 'Default values' fields by default Bug 23385: (follow-up) Update link Bug 23385: Hide 'Default values' fields by default Bug 23385: (follow-up) Update link Bug 23385: (follow-up) Update link |
Description
Nick Clemens (kidclamp)
2019-07-26 14:48:50 UTC
Created attachment 91813 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Created attachment 91838 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 91850 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Created attachment 91859 [details] [review] Bug 23385: Hide 'Default values' fields by default To test: 1 - Go to Tools->Import patrons 2 - Choose a file 3 - Scroll a long way to submit 4 - Apply patch 5 - Choose a file 6 - Can submit easily 7 - Click to expand and enter default fields 8 - Confirm can still submit and that values entered are used Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: George Williams <george@nekls.org> Created attachment 91860 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org> Created attachment 92094 [details] [review] Bug 23385: (follow-up) Update link This follow-up adds a dummy href attribute to the link for showing and hiding the default values form so that it behaves more like a link. I removed "click to" from the link text and added Font Awesome icons common to "show/hide" links. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.04 enhancement, wont backport to 18.11.x |