Bug 23385

Summary: Hide default value fields by default on patron import
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: ToolsAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, george, lucas, maryse.simard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.04
Attachments: Bug 23385: Hide 'Default values' fields by default
Bug 23385: Hide 'Default values' fields by default
Bug 23385: (follow-up) Update link
Bug 23385: Hide 'Default values' fields by default
Bug 23385: (follow-up) Update link
Bug 23385: (follow-up) Update link

Description Nick Clemens (kidclamp) 2019-07-26 14:48:50 UTC
When importing patrons there is a very long form to supply default values for patron fields. This is not always used and can be hidden unless needed to make the form display nicer
Comment 1 Nick Clemens (kidclamp) 2019-07-26 14:50:44 UTC Comment hidden (obsolete)
Comment 2 Maryse Simard 2019-07-26 18:43:02 UTC
Created attachment 91838 [details] [review]
Bug 23385: Hide 'Default values' fields by default

To test:
1 - Go to Tools->Import patrons
2 - Choose a file
3 - Scroll a long way to submit
4 - Apply patch
5 - Choose a file
6 - Can submit easily
7 - Click to expand and enter default fields
8 - Confirm can still submit and that values entered are used

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Comment 3 Owen Leonard 2019-07-29 13:03:49 UTC
Created attachment 91850 [details] [review]
Bug 23385: (follow-up) Update link

This follow-up adds a dummy href attribute to the link for showing and
hiding the default values form so that it behaves more like a link.

I removed "click to" from the link text and added Font Awesome icons
common to "show/hide" links.
Comment 4 ByWater Sandboxes 2019-07-29 22:05:59 UTC
Created attachment 91859 [details] [review]
Bug 23385: Hide 'Default values' fields by default

To test:
1 - Go to Tools->Import patrons
2 - Choose a file
3 - Scroll a long way to submit
4 - Apply patch
5 - Choose a file
6 - Can submit easily
7 - Click to expand and enter default fields
8 - Confirm can still submit and that values entered are used

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: George Williams <george@nekls.org>
Comment 5 ByWater Sandboxes 2019-07-29 22:06:01 UTC
Created attachment 91860 [details] [review]
Bug 23385: (follow-up) Update link

This follow-up adds a dummy href attribute to the link for showing and
hiding the default values form so that it behaves more like a link.

I removed "click to" from the link text and added Font Awesome icons
common to "show/hide" links.

Signed-off-by: George Williams <george@nekls.org>
Comment 6 Katrin Fischer 2019-08-08 16:28:09 UTC
Created attachment 92094 [details] [review]
Bug 23385: (follow-up) Update link

This follow-up adds a dummy href attribute to the link for showing and
hiding the default values form so that it behaves more like a link.

I removed "click to" from the link text and added Font Awesome icons
common to "show/hide" links.

Signed-off-by: George Williams <george@nekls.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Martin Renvoize 2019-08-13 13:37:48 UTC
Nice work!

Pushed to master for 19.11.00
Comment 8 Fridolin Somers 2019-09-02 13:02:28 UTC
Small enhancement, I choose to backport.

Pushed to 19.05.x for 19.05.04
Comment 9 Lucas Gass 2019-09-17 20:12:23 UTC
enhancement, wont backport to 18.11.x