Summary: | consolidate duplicate methods C4::Overdues::UpdateBorrowerDebarred and C4::Members::DebarMember | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Patrons | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | cnighswonger, katrin.fischer, koha.sekjal, paul.poulain |
Version: | 3.6 | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch to remove UpdateBorrowerDebarred
Bug 2346: Remove C4::Overdues::UpdateBorrowerDebarred in favour of C4::Members::DebarMember |
Description
Chris Cormack
2010-05-21 00:50:07 UTC
Is this bug still valid? I think there were some development for debarment of patrons since this bug was filed. This issue is resolved with the inclusion of bug 6328. UpdateBorrowerDebarred has been removed from usage except in the deprecated script notifyMailsOp.pl, and there it is overridden by a local subroutine. This script has a bug filed against it for removal (bug 7315), so I believe it is safe to remove UpdateBorrowerDebarred from C4::Overdues. Patch forthcoming. Created attachment 6564 [details] [review] Proposed patch to remove UpdateBorrowerDebarred Removes UpdateBorrowerDebarred subroutine and associated test, now that it's no longer relevant (since bug 6328) Created attachment 6584 [details] [review] Bug 2346: Remove C4::Overdues::UpdateBorrowerDebarred in favour of C4::Members::DebarMember Removes now-unused subroutine from C4::Overdues, as well as the db_dependent unit test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment: nothing to say, remove dead code. Digging into this patch to check all UpdateBorrowerDebarred calls were removed showed me that the notifyMailsOp.pl was still here. Added a follow-up to remove this script Patch pushed, please test This patch does not apply cleanly to 3.6.x branch. Please rebase over that branch and attach a corrected patch to this bug report. There have been no further reports of problems so I am marking this bug resolved. |