Bug 24653

Summary: Failing tests in 19.05.x
Product: Koha Reporter: Lucas Gass <lucas>
Component: Test SuiteAssignee: Chris Cormack <chris>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Lucas Gass 2020-02-13 14:59:42 UTC
tests are failing in 19.05:

-t/db_dependent/Koha/Charges/Fees.t
-t/db_dependent/SIP/Transaction.t

Something is not accounted for when there is no ALL/ALL circ rule.
Comment 1 Jonathan Druart 2020-02-13 15:20:32 UTC
Those tests pass for me in 19.05.x, which errors do you get?
Comment 2 Lucas Gass 2020-02-13 16:02:51 UTC
Jonathan,

Is passes for me now since the update to misc4dev. But a missing circ rule should not cause test to fail? 

This was only failing locally for me once I deleted the all/all circ rule.
Comment 3 Jonathan Druart 2020-02-13 16:03:26 UTC
(In reply to Lucas Gass from comment #2)
> Jonathan,
> 
> Is passes for me now since the update to misc4dev. But a missing circ rule
> should not cause test to fail? 
> 
> This was only failing locally for me once I deleted the all/all circ rule.

Yes, you need the default one to make the tests pass.