Bug 24653 - Failing tests in 19.05.x
Summary: Failing tests in 19.05.x
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 14:59 UTC by Lucas Gass
Modified: 2020-11-30 21:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2020-02-13 14:59:42 UTC
tests are failing in 19.05:

-t/db_dependent/Koha/Charges/Fees.t
-t/db_dependent/SIP/Transaction.t

Something is not accounted for when there is no ALL/ALL circ rule.
Comment 1 Jonathan Druart 2020-02-13 15:20:32 UTC
Those tests pass for me in 19.05.x, which errors do you get?
Comment 2 Lucas Gass 2020-02-13 16:02:51 UTC
Jonathan,

Is passes for me now since the update to misc4dev. But a missing circ rule should not cause test to fail? 

This was only failing locally for me once I deleted the all/all circ rule.
Comment 3 Jonathan Druart 2020-02-13 16:03:26 UTC
(In reply to Lucas Gass from comment #2)
> Jonathan,
> 
> Is passes for me now since the update to misc4dev. But a missing circ rule
> should not cause test to fail? 
> 
> This was only failing locally for me once I deleted the all/all circ rule.

Yes, you need the default one to make the tests pass.