Bug 26125

Summary: In 'Patron search' tab link should lead to patron details instead of checkout screen
Product: Koha Reporter: Didier Gautheron <didier.gautheron>
Component: PatronsAssignee: Didier Gautheron <didier.gautheron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, gmcharlt, kyle.m.hall, lucas, sally.healey
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03
Bug Depends on: 23697    
Bug Blocks:    
Attachments: Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Description Didier Gautheron 2020-08-03 06:37:23 UTC
Likely a copy and paste thinko.
Comment 1 Didier Gautheron 2020-08-03 08:00:09 UTC
Created attachment 107681 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed
Comment 2 ByWater Sandboxes 2020-08-03 10:07:10 UTC
Created attachment 107684 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Katrin Fischer 2020-08-05 20:10:32 UTC
Created attachment 107861 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-08-06 09:38:35 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-08-14 21:09:28 UTC
backported to 20.05.x for 20.05.03
Comment 6 Aleisha Amohia 2020-08-16 22:29:51 UTC
bug doesn't exist in 19.11.x, not backported
Comment 7 Didier Gautheron 2020-11-05 12:11:25 UTC
Hi
> bug doesn't exist in 19.11.x, not backported
As a matter of fact it does.

You have to enable PatronAutoComplete and use the auto completion menu not the 'search' button.
Comment 8 Aleisha Amohia 2020-11-05 19:45:49 UTC
(In reply to didier from comment #7)
> Hi
> > bug doesn't exist in 19.11.x, not backported
> As a matter of fact it does.
> 
> You have to enable PatronAutoComplete and use the auto completion menu not
> the 'search' button.

Good point, I tested wrong.

Regardless I think this is a minor bug and not worth backporting to oldstable.