Bug 26125 - In 'Patron search' tab link should lead to patron details instead of checkout screen
Summary: In 'Patron search' tab link should lead to patron details instead of checkout...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Didier Gautheron
QA Contact: Testopia
URL:
Keywords:
Depends on: 23697
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-03 06:37 UTC by Didier Gautheron
Modified: 2021-06-14 21:31 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03


Attachments
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search (1.52 KB, patch)
2020-08-03 08:00 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search (1.59 KB, patch)
2020-08-03 10:07 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search (1.64 KB, patch)
2020-08-05 20:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Gautheron 2020-08-03 06:37:23 UTC
Likely a copy and paste thinko.
Comment 1 Didier Gautheron 2020-08-03 08:00:09 UTC
Created attachment 107681 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed
Comment 2 ByWater Sandboxes 2020-08-03 10:07:10 UTC
Created attachment 107684 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Katrin Fischer 2020-08-05 20:10:32 UTC
Created attachment 107861 [details] [review]
Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search

Test plan:

1 - Enable PatronAutoComplete syspref
2 - Go to "Patrons" (members/members-home.pl)
3 - Enter a patron first letters in "Search Patron" tab
4 - Select a patron
5 - You're wrongly redirected in koha/circ/circulation.pl
6 - Apply patch
7 - Repeat 3, 4
8 - You're correctly redirected in koha/members/moremember.pl
9 - double check "Check out" redirect hasn't changed

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-08-06 09:38:35 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-08-14 21:09:28 UTC
backported to 20.05.x for 20.05.03
Comment 6 Aleisha Amohia 2020-08-16 22:29:51 UTC
bug doesn't exist in 19.11.x, not backported
Comment 7 Didier Gautheron 2020-11-05 12:11:25 UTC
Hi
> bug doesn't exist in 19.11.x, not backported
As a matter of fact it does.

You have to enable PatronAutoComplete and use the auto completion menu not the 'search' button.
Comment 8 Aleisha Amohia 2020-11-05 19:45:49 UTC
(In reply to didier from comment #7)
> Hi
> > bug doesn't exist in 19.11.x, not backported
> As a matter of fact it does.
> 
> You have to enable PatronAutoComplete and use the auto completion menu not
> the 'search' button.

Good point, I tested wrong.

Regardless I think this is a minor bug and not worth backporting to oldstable.