Description
wainuiwitikapark
2021-02-04 20:33:50 UTC
Created attachment 116352 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Awesome!!!! So great to see this starting to move forward. Is this ready for testing? If it is, then updating the status for 'Needs signoff' will trigger us eager beavers to take a look :) Welcome aboard. (In reply to Martin Renvoize from comment #2) > Awesome!!!! So great to see this starting to move forward. > > Is this ready for testing? If it is, then updating the status for 'Needs > signoff' will trigger us eager beavers to take a look :) > > Welcome aboard. Hey Martin! I'm still working on the second patch of this bug regarding adding <h1>s on each page. Hopefully will be done soon! Created attachment 119492 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119493 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119496 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119497 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119498 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119500 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119501 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119502 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119544 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119545 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119546 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119547 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT I just had this conflict applying patch on master : CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 27631: Changed <h1> around logo to <div> Created attachment 119830 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Created attachment 119831 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119832 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119834 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119835 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119836 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119837 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119838 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119839 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119840 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119841 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119842 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 119843 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT (In reply to Séverine Queune from comment #16) > I just had this conflict applying patch on master : > > CONFLICT (content): Merge conflict in > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt > Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss > error: Failed to merge in the changes. > Patch failed at 0001 Bug 27631: Changed <h1> around logo to <div> thanks so much for pointing this out! I have now fixed merge conflicts and re-attached patches Created attachment 120158 [details] [review] Bug 27631: (follow-up) amended aqbudgets.pl headings Added two more <h1>s to the page: Modify/Add and Delete To test: 1) Apply patch 2) Go to aqbudgets.pl 3) Check that all different pages in aqbudgets.pl have a <h1> 4) In particular, ensure that there is an <h1> on the Modify/Add page 5) In particular, ensure that there is an <h1> on the Delete page Sponsored-by: Catalyst IT Created attachment 120159 [details] [review] Bug 27631: (follow-up) amended admin/aqbudgets.pl headings Added two more <h1>s to the page: Modify/Add and Delete To test: 1) Apply patch 2) Go to admin/aqbudgets.pl 3) Check that all different pages in aqbudgets.pl have a <h1> 4) In particular, ensure that there is an <h1> on the Modify/Add page 5) In particular, ensure that there is an <h1> on the Delete page Sponsored-by: Catalyst IT Created attachment 120160 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Bug 27631: (follow-up) amended admin/aqbudgets.pl headings Added two more <h1>s to the page: Modify/Add and Delete To test: 1) Apply patch 2) Go to admin/aqbudgets.pl 3) Check that all different pages in aqbudgets.pl have a <h1> 4) In particular, ensure that there is an <h1> on the Modify/Add page 5) In particular, ensure that there is an <h1> on the Delete page Sponsored-by: Catalyst IT Bug 27631: (follow-up) amended headings admon Created attachment 120161 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 120162 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 120166 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 120190 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 120191 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Created attachment 121356 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of other heading tags, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Created attachment 121469 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Created attachment 121470 [details] [review] Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Created attachment 121522 [details] [review] Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Created attachment 121559 [details] [review] Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT On booksellers.tt, you add a "Search for vendor" h1 even though there is already an h1 on the page, "Vendor search: X results found." Is this intentional? I looks like it's redundant. The same is true on circ/bookcount.tt and on catalogue/detail.tt, where the original H1 is output by the XSL template. The labelled MARC detail page shows an error, and the QA tool catches it too: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt line 94: unexpected token (END) [% END %] On circ/branchtransfers.tt the heading "Branch transfers" uses incorrect terminology. Despite the name of the file we use the term "Library" everywhere instead of "branch." On this page however I think the heading is redundant, and the existing <legend> could probably be converted to a heading. In many files the position of the toolbar relative to the heading has been changed. I agree that we lack consistency in how this is handled, but from what I can see this patch doesn't resolve that inconsistency. I would prefer that this patchset omit the changes to toolbar position so that it can be addressed separately. Created attachment 125547 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125548 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125549 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125550 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125551 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125552 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125553 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125554 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125555 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125556 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125557 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125558 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125559 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125560 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125561 [details] [review] Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125562 [details] [review] Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125563 [details] [review] Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125564 [details] [review] Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Created attachment 127295 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127296 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127297 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127298 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127299 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127300 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127301 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127302 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127303 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127304 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127305 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127306 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127307 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127308 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127309 [details] [review] Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127310 [details] [review] Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127311 [details] [review] Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127312 [details] [review] Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Rebased. Only the last patch needs signoff! Created attachment 127432 [details] [review] Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind <david@davidnind.com> Created attachment 127433 [details] Bug 27631 - Koha header - logo + main actions and search display I have only reviewed and signed off Owen's minor corrections patch. I reviewed the patch and accessed pages I could to checked that they displayed correctly. Layout change - I'm assuming that the change where the Koha logo is displayed on its own and then the main search box (check out, check in, renew, search the catalog etc) directly under this is intentional, and will be fixed later. Screenshot attached of what I mean. Created attachment 127449 [details] [review] Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. (In reply to David Nind from comment #83) > Layout change - I'm assuming that the change where the Koha logo is > displayed on its own and then the main search box (check out, check in, > renew, search the catalog etc) directly under this is intentional Your screenshot shows the layout when the CSS hasn't been rebuilt, but it helped me notice that the alignment is still a little off even after rebuilding. My follow-up should make it better. Created attachment 127456 [details] [review] Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind <david@davidnind.com> (In reply to Owen Leonard from comment #85) > Your screenshot shows the layout when the CSS hasn't been rebuilt, but it > helped me notice that the alignment is still a little off even after > rebuilding. My follow-up should make it better. Thanks Owen - I didn't think about rebuilding the CSS! The only thing I noticed is that as it is now centered, when the screen becomes too narrow the left side of the block with the search box, submit button are off the screen, rather than left aligned as it is currently - but there are always tradeoffs, and would be unusable at this size anyway. Not considering blocker but worth nothing: You are adding h1 to a couple of "members" pages: * members/routing-lists.tt <h1>Subscription routing lists for [% INCLUDE 'patron-title.inc' %]</h1> * members/boraccount.tt <h1>Account for [% INCLUDE 'patron-title.inc' %]</h1> However most of the other views of the "members" module have the h1 without the patron's name: "Circulation history", "Checkouts", "Holds history". There is something that is problematic, the [% INCLUDE 'blocking_errors.inc' %] should not be moved, it must be at the very beginning (right after main). The script will stop early (after the INCLUDE) and we don't want to display anything else before as the template won't receive the correct data in most of the cases. Hi Wainui, starting to look here - do you have time for following up on the 2 last comments from Jonathan? I think at least the second requires a follow up ([% INCLUDE 'blocking_errors.inc' %]) For the patron names I believe it might be easier to focus on the h1 issue first and then maybe figure out if we want to add patron names to all the pages in question, but if you think it's important to keep them, please let me know. Patches still apply and QA tests pass! Created attachment 131069 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131070 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131071 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131072 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131073 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131074 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131075 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131076 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131077 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131078 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131079 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131080 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131081 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131082 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131083 [details] [review] Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131084 [details] [review] Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131085 [details] [review] Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 131086 [details] [review] Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind <david@davidnind.com> Created attachment 131087 [details] [review] Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind <david@davidnind.com> Hi Owen, a little hard to see here that you have taken care of Jonathan's comments - can you add a comment at the end next time please? Almost there, some small things I noticed while testing: 1) Doubled up information http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=32 Information appears doubled up: Pamela Bennett (23529000318858) Pamela Bennett (23529000318858) 2) Position of headline http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=32 http://localhost:8081/cgi-bin/koha/members/pay.pl?borrowernumber=32 The heading appears above the toolbar, on all other pages it's below, which I think is better. 3) No heading http://localhost:8081/cgi-bin/koha/admin/edi_ean_accounts.pl http://localhost:8081/cgi-bin/koha/admin/items_search_fields.pl http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl 4) Typo http://localhost:8081/cgi-bin/koha/admin/z3950servers.pl Z19.50/SRU servers administration 5) Reword heading h1? Classification sources Classification sources h1 and h2 here are the same, maybe we should adjust h1 and the link on the admin page to have a wider scope and fit better. Created attachment 131192 [details] [review] Bug 27631: (follow-up) Various corrections This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" Created attachment 132886 [details] [review] Bug 27631: Changed <h1> around logo to <div> To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside <div> and not <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132887 [details] [review] Bug 27631: circ folder Changed each of the pages in the circ folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132888 [details] [review] Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132889 [details] [review] Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132890 [details] [review] Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside <div> and not inside <h1> 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132891 [details] [review] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132892 [details] [review] Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132893 [details] [review] Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132894 [details] [review] Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132895 [details] [review] Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132896 [details] [review] Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132897 [details] [review] Bug 27631: Hidden <h1> on intranet-main.tt This patch visually hides a <h1> on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the <h1> "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132898 [details] [review] Bug 27631: admin folder Changed each of the pages in the admin folder to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132899 [details] [review] Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132900 [details] [review] Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132901 [details] [review] Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132902 [details] [review] Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one <h1> tag showing that describes the page, rather than the <h1> around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132903 [details] [review] Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132904 [details] [review] Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132905 [details] [review] Bug 27631: (follow-up) Various corrections This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thank you for the follow-up, Owen! Sorry it took me so long to get back to this one, I think it's about time we get this one in! Pushed to master for 22.05, thanks to everybody involved 🦄 I add to resolve some conflicts on patrons search due to Bug 30063 I fixed to h1 to div in follow-up : https://git.koha-community.org/Koha-community/Koha/commit/05ba079814facb569feb9327992a1dc441753754 Feel free to add some other follow-up if needed. Best regards, In virtualshelves/shelves.tt - <legend>Create a new list</legend> + <legend><h1>Create a new list</h1></legend> This is wrong, h1 is too big for a fieldset's legend. |