Bug 30774 - Typo: i %sEdit %sReserve %s
Summary: Typo: i %sEdit %sReserve %s
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 27631
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-16 12:16 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01


Attachments
Bug 30774: Typo: i %sEdit %sReserve %s (2.21 KB, patch)
2022-05-17 11:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30774: Typo: i %sEdit %sReserve %s (2.27 KB, patch)
2022-05-17 19:24 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30774: Typo: i %sEdit %sReserve %s (2.34 KB, patch)
2022-05-18 13:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-16 12:16:01 UTC
The single i here seems misplaced:


koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt:33
i %sEdit %sReserve %s
Comment 1 Owen Leonard 2022-05-17 11:53:31 UTC
Created attachment 135059 [details] [review]
Bug 30774: Typo: i %sEdit %sReserve %s

This patch removes an out of place "i" and replaces it with a space. The
patch also removes obsolete CDATA markers in the page's JavaScript.

To test, apply the patch and go to Course reserves.

- Create a course if necessary, then view the details of your course.
- Click the "Add reserves" button.
- Enter a barcode or biblionumber.
- On the next page, the heading "Reserve [title] for [course]" should
  look correct, with no extra "i" at the beginning of the line.
Comment 2 Lucas Gass 2022-05-17 19:24:36 UTC
Created attachment 135078 [details] [review]
Bug 30774: Typo: i %sEdit %sReserve %s

This patch removes an out of place "i" and replaces it with a space. The
patch also removes obsolete CDATA markers in the page's JavaScript.

To test, apply the patch and go to Course reserves.

- Create a course if necessary, then view the details of your course.
- Click the "Add reserves" button.
- Enter a barcode or biblionumber.
- On the next page, the heading "Reserve [title] for [course]" should
  look correct, with no extra "i" at the beginning of the line.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2022-05-18 13:03:32 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2022-05-18 13:03:59 UTC
> The patch also removes obsolete CDATA markers in the page's JavaScript.

Can you open an enhancement request on the qa-test-tools project please?
Comment 5 Jonathan Druart 2022-05-18 13:04:27 UTC
Created attachment 135108 [details] [review]
Bug 30774: Typo: i %sEdit %sReserve %s

This patch removes an out of place "i" and replaces it with a space. The
patch also removes obsolete CDATA markers in the page's JavaScript.

To test, apply the patch and go to Course reserves.

- Create a course if necessary, then view the details of your course.
- Click the "Add reserves" button.
- Enter a barcode or biblionumber.
- On the next page, the heading "Reserve [title] for [course]" should
  look correct, with no extra "i" at the beginning of the line.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Fridolin Somers 2022-05-19 03:22:01 UTC
VIM did it ^^
Comment 7 Tomás Cohen Arazi 2022-06-01 19:02:31 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-06-10 14:49:01 UTC
Pushed to 22.05.x for 22.05.01
Comment 9 Arthur Suzuki 2022-06-21 08:49:35 UTC
Not backporting, not relevant to 21.11