Summary: | z_reset.t is wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | martin.renvoize, matt.blenkinsop |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01
|
|
Bug Depends on: | 22709 | ||
Bug Blocks: | |||
Attachments: |
Bug 29274: Remove z_reset.t
Bug 29274: Remove z_reset.t |
Description
Jonathan Druart
2021-10-19 14:03:42 UTC
Shouldn't we actually deal with that at the end of test scripts playing with plugins? ping Martin? I don't remember writing this to be honest. I thought the tests within a directory ran in order at the time. Created attachment 144341 [details] [review] Bug 29274: Remove z_reset.t From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77 """ Bug 22709: (RM follow-up) Clean up plugin tests The plugin tests were failing due to failed rollbacks and run order. This patch moves them into their own directory and adds a reset test to restore the original state of the plugin system after the tests have run. """ This is wrong, the tests are run in a random order. We don't need this file. Created attachment 144342 [details] [review] Bug 29274: Remove z_reset.t From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77 """ Bug 22709: (RM follow-up) Clean up plugin tests The plugin tests were failing due to failed rollbacks and run order. This patch moves them into their own directory and adds a reset test to restore the original state of the plugin system after the tests have run. """ This is wrong, the tests are run in a random order. We don't need this file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix, straight removal. Going straight for QA, Passed. Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Nice work everyone! Pushed to stable for 22.11.x |