Bug 29274 - z_reset.t is wrong
Summary: z_reset.t is wrong
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 22709
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-19 14:03 UTC by Jonathan Druart
Modified: 2024-07-04 20:38 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01
Circulation function:

Attachments
Bug 29274: Remove z_reset.t (1.89 KB, patch)
2022-11-30 09:52 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 29274: Remove z_reset.t (1.96 KB, patch)
2022-11-30 10:08 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2021-10-19 14:03:42 UTC 
From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77

"""
    Bug 22709: (RM follow-up) Clean up plugin tests
    
    The plugin tests were failing due to failed rollbacks and run order.
    This patch moves them into their own directory and adds a reset test to
    restore the original state of the plugin system after the tests have
    run.
"""

This is wrong, the tests are run in a random order.
Comment 1 Jonathan Druart 2021-10-22 12:23:16 UTC 
Shouldn't we actually deal with that at the end of test scripts playing with plugins?
Comment 2 Jonathan Druart 2022-11-22 08:51:58 UTC 
ping Martin?
Comment 3 Martin Renvoize (ashimema) 2022-11-25 16:02:26 UTC 
I don't remember writing this to be honest.  I thought the tests within a directory ran in order at the time.
Comment 4 Jonathan Druart 2022-11-30 09:52:35 UTC 
Created attachment 144341 [details] [review]
Bug 29274: Remove z_reset.t

From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77

"""
    Bug 22709: (RM follow-up) Clean up plugin tests

    The plugin tests were failing due to failed rollbacks and run order.
    This patch moves them into their own directory and adds a reset test to
    restore the original state of the plugin system after the tests have
    run.
"""

This is wrong, the tests are run in a random order.

We don't need this file.
Comment 5 Martin Renvoize (ashimema) 2022-11-30 10:08:36 UTC 
Created attachment 144342 [details] [review]
Bug 29274: Remove z_reset.t

From the description of commit d25f3e84374ec8d7c85f8ed805102f67c0a73d77

"""
    Bug 22709: (RM follow-up) Clean up plugin tests

    The plugin tests were failing due to failed rollbacks and run order.
    This patch moves them into their own directory and adds a reset test to
    restore the original state of the plugin system after the tests have
    run.
"""

This is wrong, the tests are run in a random order.

We don't need this file.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2022-11-30 10:09:09 UTC 
Trivial fix, straight removal.

Going straight for QA, Passed.
Comment 7 Tomás Cohen Arazi (tcohen) 2022-12-01 13:04:23 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2022-12-05 11:54:22 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Matt Blenkinsop 2022-12-05 12:06:14 UTC 
Nice work everyone!

Pushed to stable for 22.11.x