Bug 30776

Summary: import_webservice_batch.pl cronjob completely broken
Product: Koha Reporter: Joonas Kylmälä <joonas.kylmala>
Component: Command-line UtilitiesAssignee: Joonas Kylmälä <joonas.kylmala>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: m.de.rooy, robin
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Attachments: Bug 30776: import missing subroutine to fix import_webservice_batch.pl
Bug 30776: import missing subroutine to fix import_webservice_batch.pl

Description Joonas Kylmälä 2022-05-16 18:52:45 UTC
The import_webservice_batch.pl cronjob doesn't work at all due to a missing import.

> $ perl misc/cronjobs/import_webservice_batch.pl 
> Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46

Not sure if anyone uses this but this is an easy fix, we can remove the feature later if it is unused.
Comment 1 Joonas Kylmälä 2022-05-16 18:59:48 UTC
Created attachment 135046 [details] [review]
Bug 30776: import missing subroutine to fix import_webservice_batch.pl

Test plan:
 1) Apply patch and notice the following error is gone:
    $ perl misc/cronjobs/import_webservice_batch.pl
    Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46.
Comment 2 Joonas Kylmälä 2022-05-16 19:01:08 UTC
Moving directly to signed-off since this is a very trivial patch.
Comment 3 Marcel de Rooy 2022-05-18 11:21:12 UTC
Created attachment 135099 [details] [review]
Bug 30776: import missing subroutine to fix import_webservice_batch.pl

Test plan:
 1) Apply patch and notice the following error is gone:
    $ perl misc/cronjobs/import_webservice_batch.pl
    Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2022-05-18 11:21:48 UTC
I really wonder how many people are using this?
Comment 5 Fridolin Somers 2022-05-19 03:23:11 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄