Bug 30776 - import_webservice_batch.pl cronjob completely broken
Summary: import_webservice_batch.pl cronjob completely broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Joonas Kylmälä
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-16 18:52 UTC by Joonas Kylmälä
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Circulation function:

Attachments
Bug 30776: import missing subroutine to fix import_webservice_batch.pl (1.06 KB, patch)
2022-05-16 18:59 UTC, Joonas Kylmälä 		Details | Diff | Splinter Review
Bug 30776: import missing subroutine to fix import_webservice_batch.pl (1.16 KB, patch)
2022-05-18 11:21 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2022-05-16 18:52:45 UTC 
The import_webservice_batch.pl cronjob doesn't work at all due to a missing import.

> $ perl misc/cronjobs/import_webservice_batch.pl 
> Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46

Not sure if anyone uses this but this is an easy fix, we can remove the feature later if it is unused.
Comment 1 Joonas Kylmälä 2022-05-16 18:59:48 UTC 
Created attachment 135046 [details] [review]
Bug 30776: import missing subroutine to fix import_webservice_batch.pl

Test plan:
 1) Apply patch and notice the following error is gone:
    $ perl misc/cronjobs/import_webservice_batch.pl
    Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46.
Comment 2 Joonas Kylmälä 2022-05-16 19:01:08 UTC 
Moving directly to signed-off since this is a very trivial patch.
Comment 3 Marcel de Rooy 2022-05-18 11:21:12 UTC 
Created attachment 135099 [details] [review]
Bug 30776: import missing subroutine to fix import_webservice_batch.pl

Test plan:
 1) Apply patch and notice the following error is gone:
    $ perl misc/cronjobs/import_webservice_batch.pl
    Undefined subroutine &main::GetStagedWebserviceBatches called at misc/cronjobs/import_webservice_batch.pl line 46.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2022-05-18 11:21:48 UTC 
I really wonder how many people are using this?
Comment 5 Fridolin Somers 2022-05-19 03:23:11 UTC 
Pushed to master for 22.05, thanks to everybody involved ﷐[U+1F984]﷑