Bug 31677

Summary: Convert basic MARC editor tabs to Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: arthur.suzuki, barbara.johnson, lucas, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08
Bug Depends on: 31678    
Bug Blocks: 29226    
Attachments: Bug 31677: Convert basic MARC editor tabs to Bootstrap
Bug 31677: Convert basic MARC editor tabs to Bootstrap
Bug 31677: Convert basic MARC editor tabs to Bootstrap

Description Owen Leonard 2022-10-04 17:43:14 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the basic MARC editor (addbiblio.tt)
Comment 1 Owen Leonard 2022-10-06 18:53:17 UTC Comment hidden (obsolete)
Comment 2 PTFS Europe Sandboxes 2022-10-07 17:16:24 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2022-10-07 21:05:15 UTC
Created attachment 141529 [details] [review]
Bug 31677: Convert basic MARC editor tabs to Bootstrap

This patch modifies the basic MARC editor template to replace jQueryUI
tabs with Bootstrap tabs. The changes should have no visible effect,
with all previous functionality still intact.

To test, apply the patch and go to Cataloging -> New record.

- When the page first displays, the "0" tab should be active.
- Test that each of the numbered tabs works correctly to activate the
  correct tab content.
- Confirm that the numbered tag anchors still work correctly.
- Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh
  the page (you may need to shift-refresh). When the page reloads the
  correct tab should be active by default.
- Try appending a query string to the URL, e.g. "?tab=tab4XX" This
  should reload the page and make the correct tab active.
- Confirm that sortable subfields can still be re-ordered by dragging
  and dropping them via the "stacked lines" icons.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-10-12 12:47:04 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-05 18:33:53 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Arthur Suzuki 2022-12-14 15:09:34 UTC
enhancement, conflicts when trying to apply, won't backport