Bug 31678 - Convert authority editor tabs to Bootstrap
Summary: Convert authority editor tabs to Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 29226 31677
  Show dependency treegraph
 
Reported: 2022-10-04 17:45 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08


Attachments
Bug 31678: Convert authority editor tabs to Bootstrap (47.90 KB, patch)
2022-10-06 11:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31678: Convert authority editor tabs to Bootstrap (47.97 KB, patch)
2022-10-06 12:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31678: Convert authority editor tabs to Bootstrap (47.98 KB, patch)
2022-10-06 17:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31678: Convert authority editor tabs to Bootstrap (48.03 KB, patch)
2022-10-07 20:59 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31678: Convert authority editor tabs to Bootstrap (48.10 KB, patch)
2022-10-07 21:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-04 17:45:09 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the authorities editor (authorities.tt)
Comment 1 Owen Leonard 2022-10-06 11:43:17 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2022-10-06 12:29:01 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2022-10-06 17:59:48 UTC
Created attachment 141465 [details] [review]
Bug 31678: Convert authority editor tabs to Bootstrap

This patch modifies the authorities editor template to replace jQueryUI
tabs with Bootstrap tabs. The changes should have no visible effect,
with all previous functionality still intact.

To test, apply the patch and go to Authorities -> New authority.

- When the page first displays, the "0" tab should be active.
- Test that each of the numbered tabs works correctly to activate the
  correct tab content.
- Confirm that the numbered tag anchors still work correctly.
- Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh
  the page (you may need to shift-refresh). When the page reloads the
  correct tab should be active by default.
- Confirm that sortable subfields can still be re-ordered by dragging
  and dropping them via the "stacked lines" icons.
Comment 4 Barbara Johnson 2022-10-07 17:37:53 UTC
This worked as expected.  However, I could not test the last step.  None of the authorities contained more than one subfield so I couldn't test the sortability via dragging/dropping.  Authorities in my local system are the same - no tag had more than one subfield.
Comment 5 Katrin Fischer 2022-10-07 20:59:34 UTC
Created attachment 141527 [details] [review]
Bug 31678: Convert authority editor tabs to Bootstrap

This patch modifies the authorities editor template to replace jQueryUI
tabs with Bootstrap tabs. The changes should have no visible effect,
with all previous functionality still intact.

To test, apply the patch and go to Authorities -> New authority.

- When the page first displays, the "0" tab should be active.
- Test that each of the numbered tabs works correctly to activate the
  correct tab content.
- Confirm that the numbered tag anchors still work correctly.
- Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh
  the page (you may need to shift-refresh). When the page reloads the
  correct tab should be active by default.
- Confirm that sortable subfields can still be re-ordered by dragging
  and dropping them via the "stacked lines" icons.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-10-07 21:00:36 UTC
Created attachment 141528 [details] [review]
Bug 31678: Convert authority editor tabs to Bootstrap

This patch modifies the authorities editor template to replace jQueryUI
tabs with Bootstrap tabs. The changes should have no visible effect,
with all previous functionality still intact.

To test, apply the patch and go to Authorities -> New authority.

- When the page first displays, the "0" tab should be active.
- Test that each of the numbered tabs works correctly to activate the
  correct tab content.
- Confirm that the numbered tag anchors still work correctly.
- Append a specific tab anchor to the URL, e.g. "#tab4XX" and refresh
  the page (you may need to shift-refresh). When the page reloads the
  correct tab should be active by default.
- Confirm that sortable subfields can still be re-ordered by dragging
  and dropping them via the "stacked lines" icons.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-10-07 21:01:16 UTC
(In reply to Barbara Johnson from comment #4)
> This worked as expected.  However, I could not test the last step.  None of
> the authorities contained more than one subfield so I couldn't test the
> sortability via dragging/dropping.  Authorities in my local system are the
> same - no tag had more than one subfield.

Thx for testing Barbara! I added your sign-off line and made sure the drag&drop is working ok.
Comment 8 Tomás Cohen Arazi 2022-10-12 12:47:10 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 9 Lucas Gass 2022-12-05 18:29:32 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 10 Arthur Suzuki 2022-12-14 15:08:53 UTC
enhancement, conflicts when trying to apply, won't backport