Bug 31682

Summary: Silence warn when using automatic linker in biblio editor
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: CatalogingAssignee: Aleisha Amohia <aleisha>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, lucas, m.de.rooy, wainuiwitikapark
Version: 22.05   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15
Attachments: Bug 31682: Silence automatic linker warn
Bug 31682: Silence automatic linker warn
Bug 31682: Silence automatic linker warn

Description Aleisha Amohia 2022-10-04 21:23:49 UTC
When cataloguing a biblio and you use the 'link authorities automatically' button, there is a warn in the logs that could be silenced:

[WARN] CGI::param called in list context from /home/vagrant/kohaclone/svc/cataloguing/automatic_linker.pl line 52, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412.
Comment 1 Aleisha Amohia 2022-10-04 21:25:46 UTC
Created attachment 141331 [details] [review]
Bug 31682: Silence automatic linker warn

To test:
1. Open the plack-intranet-error.log in your terminal
2. When editing or adding a bibliographic record, click the button to
link authorities automatically.
3. Notice the warn in the log
4. Apply the patch, restart services and refresh the page
5. Click the button again. There should be no warn

Sponsored-by: Catalyst IT
Comment 2 David Nind 2022-10-06 20:45:36 UTC
Created attachment 141473 [details] [review]
Bug 31682: Silence automatic linker warn

To test:
1. Open the plack-intranet-error.log in your terminal
2. When editing or adding a bibliographic record, click the button to
link authorities automatically.
3. Notice the warn in the log
4. Apply the patch, restart services and refresh the page
5. Click the button again. There should be no warn

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2022-10-07 06:19:37 UTC
Created attachment 141476 [details] [review]
Bug 31682: Silence automatic linker warn

To test:
1. Open the plack-intranet-error.log in your terminal
2. When editing or adding a bibliographic record, click the button to
link authorities automatically.
3. Notice the warn in the log
4. Apply the patch, restart services and refresh the page
5. Click the button again. There should be no warn

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2022-10-11 14:21:45 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-05 18:17:13 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Arthur Suzuki 2022-12-14 14:32:54 UTC
applied to 21.11 for 21.11.15
Comment 7 wainuiwitikapark 2023-03-15 00:51:54 UTC
Not backported to 21.05.x