When cataloguing a biblio and you use the 'link authorities automatically' button, there is a warn in the logs that could be silenced: [WARN] CGI::param called in list context from /home/vagrant/kohaclone/svc/cataloguing/automatic_linker.pl line 52, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412.
Created attachment 141331 [details] [review] Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT
Created attachment 141473 [details] [review] Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141476 [details] [review] Bug 31682: Silence automatic linker warn To test: 1. Open the plack-intranet-error.log in your terminal 2. When editing or adding a bibliographic record, click the button to link authorities automatically. 3. Notice the warn in the log 4. Apply the patch, restart services and refresh the page 5. Click the button again. There should be no warn Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08
applied to 21.11 for 21.11.15
Not backported to 21.05.x