Bug 31711

Summary: When creating order lines "From a new file" you are no longer redirected to acq after import
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: AcquisitionsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: andrewfh, jonathan.druart, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31891
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31892
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 27421    
Bug Blocks:    
Attachments: Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

Description Katrin Fischer 2022-10-07 13:49:01 UTC
With the new RabbitMQ based importer, you get 'stuck' on the import took when using the "From a new file" option to create a new order line.
You should be able to return back to acq and see your uploaded records for ordering.
Comment 1 Katrin Fischer 2022-11-14 21:28:52 UTC
This renders the upload functionality in acq useless. If it's too hard to do the correct redirect with the jobs in between - should we remove the file upload option or maybe open it in a new tab so the connection to the basket is not totally lost?
Comment 2 Jonathan Druart 2022-11-15 08:10:42 UTC
Created attachment 143892 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.
Comment 3 Jonathan Druart 2022-11-15 08:11:59 UTC
Would that work for you, Katrin?
Comment 4 Nick Clemens (kidclamp) 2022-11-15 13:35:40 UTC
Created attachment 143902 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2022-11-15 14:36:41 UTC
Created attachment 143907 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Andrew Fuerste-Henry 2022-11-15 20:12:01 UTC
Thanks for filing and patching this! I've added See Alsos to a couple of related bugs that I'm hoping this might fix incidentally.
Comment 7 Tomás Cohen Arazi 2022-11-15 22:24:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!