Bug 31711 - When creating order lines "From a new file" you are no longer redirected to acq after import
Summary: When creating order lines "From a new file" you are no longer redirected to a...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 27421
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-07 13:49 UTC by Katrin Fischer
Modified: 2023-06-08 22:29 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file (2.56 KB, patch)
2022-11-15 08:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file (2.61 KB, patch)
2022-11-15 13:35 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file (2.67 KB, patch)
2022-11-15 14:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-07 13:49:01 UTC
With the new RabbitMQ based importer, you get 'stuck' on the import took when using the "From a new file" option to create a new order line.
You should be able to return back to acq and see your uploaded records for ordering.
Comment 1 Katrin Fischer 2022-11-14 21:28:52 UTC
This renders the upload functionality in acq useless. If it's too hard to do the correct redirect with the jobs in between - should we remove the file upload option or maybe open it in a new tab so the connection to the basket is not totally lost?
Comment 2 Jonathan Druart 2022-11-15 08:10:42 UTC
Created attachment 143892 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.
Comment 3 Jonathan Druart 2022-11-15 08:11:59 UTC
Would that work for you, Katrin?
Comment 4 Nick Clemens 2022-11-15 13:35:40 UTC
Created attachment 143902 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2022-11-15 14:36:41 UTC
Created attachment 143907 [details] [review]
Bug 31711: (bug 27421 follow-up) Fix add to basket from a new file

We lost the display of the "Add staged files to basket" link when create
a new order from a new file

Test plan:
Add order to basket from a new file, select a file and import
See the detail of the job and notice the "Add staged files to basket",
click and confirm that it works as expected.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Andrew Fuerste-Henry 2022-11-15 20:12:01 UTC
Thanks for filing and patching this! I've added See Alsos to a couple of related bugs that I'm hoping this might fix incidentally.
Comment 7 Tomás Cohen Arazi 2022-11-15 22:24:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!