Bug 31888

Summary: In Elasticsearch mappings page save button should be yellow
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: TemplatesAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 31947    
Attachments: Bug 31888: Define save button as primary in Elasticsearch mappings page
Bug 31888: Define save button as primary in Elasticsearch mappings page
Bug 31888: Define save button as primary in Elasticsearch mappings page

Description Fridolin Somers 2022-10-20 08:28:40 UTC
Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.
Comment 1 Fridolin Somers 2022-10-20 08:34:46 UTC
Created attachment 142231 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow
Comment 2 David Nind 2022-10-20 13:18:35 UTC
Created attachment 142243 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 08:35:24 UTC
Created attachment 142304 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2022-10-24 14:46:10 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!