Bug 31810 - Place hold button should be yellow
Summary: Place hold button should be yellow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 30952
Blocks: 31947
  Show dependency treegraph
 
Reported: 2022-10-15 07:37 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31810: Define 'Place hold' button as primary (4.83 KB, patch)
2022-10-20 01:49 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 31810: Define 'Place hold' button as primary (4.88 KB, patch)
2022-10-20 02:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 31810: Define 'Place hold' button as primary (4.97 KB, patch)
2022-10-21 07:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-15 07:37:58 UTC
When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.
Comment 1 Fridolin Somers 2022-10-20 01:28:58 UTC
I see Bug 23957 changed from input to button
Comment 2 Fridolin Somers 2022-10-20 01:41:52 UTC
Looks like important action button must use btn-primary instead of btn-default

https://getbootstrap.com/docs/4.0/components/buttons/#examples
Comment 3 Fridolin Somers 2022-10-20 01:49:34 UTC
Created attachment 142220 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available
Comment 4 Fridolin Somers 2022-10-20 01:50:45 UTC
We see this patch did the same on preferences page :
Bug 30952: Set preferences save buttons as primary buttons
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679
Comment 5 David Nind 2022-10-20 02:34:59 UTC
Created attachment 142223 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Marcel de Rooy 2022-10-21 07:03:15 UTC
Fridolin: penalty points for not filling Assignee field. You should know.
Comment 7 Marcel de Rooy 2022-10-21 07:03:48 UTC
Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :)
Comment 8 Marcel de Rooy 2022-10-21 07:04:24 UTC
Created attachment 142294 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Tomás Cohen Arazi 2022-10-21 12:58:57 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2022-10-21 19:29:10 UTC
(In reply to Marcel de Rooy from comment #6)
> Fridolin: penalty points for not filling Assignee field. You should know.

Oupsy, I need more coffee (or more IPA) ^^
Tanks for fixing