Bug 31902

Summary: Inconsistent table formatting for 'Existing holds'
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Staff interfaceAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, gmcharlt, katrin.fischer, koha-bugs, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 31833    
Attachments: Bug 31902: Next header row inside a thead
Bug 31902: Next header row inside a thead

Description Martin Renvoize 2022-10-21 09:16:16 UTC
The table(s) on reserves/request.pl for Existing holds have inconsistent formatting. The top header is missing a line beneath it for each table which is inconsistent with other pages.
Comment 1 David Nind 2022-10-23 22:57:52 UTC
See screenshots attached to bug 31806 to see what this looks like.
Comment 2 Martin Renvoize 2022-11-08 15:52:22 UTC
Created attachment 143444 [details] [review]
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.
Comment 3 Martin Renvoize 2022-11-08 15:54:20 UTC
I can't entirely remember if there was anything else here.. could you verify that it was just the header underline we were concerned with David?
Comment 4 David Nind 2022-11-09 12:13:19 UTC
Created attachment 143494 [details] [review]
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2022-11-09 12:14:59 UTC
(In reply to Martin Renvoize from comment #3)
> I can't entirely remember if there was anything else here.. could you verify
> that it was just the header underline we were concerned with David?

I think that was it - button issue (light gray background) was fixed on another bug.
Comment 6 Tomás Cohen Arazi 2022-11-09 17:40:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!