Bug 31902 - Inconsistent table formatting for 'Existing holds'
Summary: Inconsistent table formatting for 'Existing holds'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31833
  Show dependency treegraph
 
Reported: 2022-10-21 09:16 UTC by Martin Renvoize
Modified: 2023-06-08 22:28 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31902: Next header row inside a thead (2.52 KB, patch)
2022-11-08 15:52 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31902: Next header row inside a thead (2.56 KB, patch)
2022-11-09 12:13 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-21 09:16:16 UTC
The table(s) on reserves/request.pl for Existing holds have inconsistent formatting. The top header is missing a line beneath it for each table which is inconsistent with other pages.
Comment 1 David Nind 2022-10-23 22:57:52 UTC
See screenshots attached to bug 31806 to see what this looks like.
Comment 2 Martin Renvoize 2022-11-08 15:52:22 UTC
Created attachment 143444 [details] [review]
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.
Comment 3 Martin Renvoize 2022-11-08 15:54:20 UTC
I can't entirely remember if there was anything else here.. could you verify that it was just the header underline we were concerned with David?
Comment 4 David Nind 2022-11-09 12:13:19 UTC
Created attachment 143494 [details] [review]
Bug 31902: Next header row inside a thead

This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2022-11-09 12:14:59 UTC
(In reply to Martin Renvoize from comment #3)
> I can't entirely remember if there was anything else here.. could you verify
> that it was just the header underline we were concerned with David?

I think that was it - button issue (light gray background) was fixed on another bug.
Comment 6 Tomás Cohen Arazi 2022-11-09 17:40:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!