Bug 31991

Summary: Restore style of sidebar forms
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: david, lucas
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31998
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Bug 31991: Restore style of sidebar forms
Bug 31991: Restore style of sidebar forms
k
Bug 31991: Restore style of sidebar forms

Description Owen Leonard 2022-10-26 14:16:32 UTC
A lot of changes were made the the style of sidebar forms (usually filter forms in an <aside> which I don't think were necessary to keep with the new design. I think it would be better to keep (and tweak) the old CSS.
Comment 1 Owen Leonard 2022-10-26 14:41:26 UTC
Created attachment 142673 [details] [review]
Bug 31991: Restore style of sidebar forms

This patch restores the aside{} section of staff-global.scss from before
the staff redesign and makes some tweaks to make it consisten with the
redesign. The goal is to make the spacing of the form more compact but
still readable, and to correct some layout inconsistencies.

The patch also modifies the order filter form to fix the layout of some
checkboxes.

To test, apply the patch and rebuild the staff interface CSS.

Test various pages with sidebar forms to confirm that the form looks
readable and usable. For example:

- Patrons
- Acquisitions -> Invoices
- Tools -> Tags
- Serials -> Subscription search results
- Overdues
- Holds to pull
Comment 2 David Nind 2022-10-26 20:30:13 UTC
Created attachment 142684 [details] [review]
Bug 31991: Restore style of sidebar forms

This patch restores the aside{} section of staff-global.scss from before
the staff redesign and makes some tweaks to make it consisten with the
redesign. The goal is to make the spacing of the form more compact but
still readable, and to correct some layout inconsistencies.

The patch also modifies the order filter form to fix the layout of some
checkboxes.

To test, apply the patch and rebuild the staff interface CSS.

Test various pages with sidebar forms to confirm that the form looks
readable and usable. For example:

- Patrons
- Acquisitions -> Invoices
- Tools -> Tags
- Serials -> Subscription search results
- Overdues
- Holds to pull

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-10-26 20:35:46 UTC
Not sure about these ones, as I think they are outside the scope of this bug.

Happy to add separate bugs for these to fix up the form inconsistencies.

1. Acquisitions > Suggestions management: has expandable sections that open when clicked with the form for each option - there is no space between the last field and the button(s), there is no space before the left margin for the "Filter by:" heading.

2. Administration > Budgets > All funds: "Filters" link outside the filter box, here is no space between the last field and the button(s), grey space after before the other sidebar options.

3. Tools > Tags: apply filters button has no colour

4. Tools > News: the heading "Filter" is outside the box with the white background, there is no "Action" button - but selections work, however, there is a grey background line after the end of the filter and the other sidebar options.

5. Tools > Pages: same as for Tools > News.

6. Reports > Use saved: Gray space before buttons, no white space after.

Others checked:
- Acquisitions > Late orders: OK.
Comment 4 Katrin Fischer 2022-10-26 21:19:57 UTC
Created attachment 142685 [details] [review]
k
Comment 5 Katrin Fischer 2022-10-26 21:20:58 UTC
Created attachment 142686 [details] [review]
Bug 31991: Restore style of sidebar forms

This patch restores the aside{} section of staff-global.scss from before
the staff redesign and makes some tweaks to make it consisten with the
redesign. The goal is to make the spacing of the form more compact but
still readable, and to correct some layout inconsistencies.

The patch also modifies the order filter form to fix the layout of some
checkboxes.

To test, apply the patch and rebuild the staff interface CSS.

Test various pages with sidebar forms to confirm that the form looks
readable and usable. For example:

- Patrons
- Acquisitions -> Invoices
- Tools -> Tags
- Serials -> Subscription search results
- Overdues
- Holds to pull

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-27 12:45:06 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!