Bug 32061

Summary: <span> in the title of z39.50 servers page
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01
Attachments: Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

Description Caroline Cyr La Rose 2022-11-01 19:19:46 UTC
When accessing the Z39.50 servers page, in the title of the page (what appears in the browser tab) there are html tags <span>.

To test:
1. Go to Administration > Z39.50/SRU servers
2. Click "New Z39.50 server"
   --> Notice in the browser tab, the title of the page is New <span>Z39.50</span> server > ...

It does this for new Z39.50 server, new SRU server and when editing a server too.
Comment 1 Katrin Fischer 2022-11-16 22:50:47 UTC
Created attachment 143978 [details] [review]
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.
Comment 2 David Nind 2022-11-17 18:45:00 UTC
Created attachment 144024 [details] [review]
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

Signed-off-by: David <david@davidnind.com>
Comment 3 Hammat wele 2022-11-17 20:40:52 UTC
Created attachment 144041 [details] [review]
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

Signed-off-by: David <david@davidnind.com>
Signed-off-by: hammat <hammat@inlibro.com>
Comment 4 Tomás Cohen Arazi 2022-12-15 12:44:24 UTC
Created attachment 144612 [details] [review]
Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers

In another bug we added spans to ease translations in the PROCESS
block for server types. This PROCESS is used in several places,
but only creates a problem when used in the title.

The patch removes the spans using the remove TT filter avoiding
having to change the PROCESS and causing a string change.

To test:
* Go to administration > Z39.50/SRU servers
* Add a new Z39.50 and a SRU server or look at the form
* The page title in the browser tab will show the span
* Same for editing an existing Z39.50 or SRU server
* Apply the patch
* Verify the page titles are now correct

Hint: you can see the full page title when hovering on the tab.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Hammat Wele <hammat@inlibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2022-12-15 12:58:29 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2022-12-15 14:05:55 UTC
Nice work everyone!

Pushed to 22.11.x for the next release