When accessing the Z39.50 servers page, in the title of the page (what appears in the browser tab) there are html tags <span>. To test: 1. Go to Administration > Z39.50/SRU servers 2. Click "New Z39.50 server" --> Notice in the browser tab, the title of the page is New <span>Z39.50</span> server > ... It does this for new Z39.50 server, new SRU server and when editing a server too.
Created attachment 143978 [details] [review] Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab.
Created attachment 144024 [details] [review] Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David <david@davidnind.com>
Created attachment 144041 [details] [review] Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David <david@davidnind.com> Signed-off-by: hammat <hammat@inlibro.com>
Created attachment 144612 [details] [review] Bug 32061: Remove spans from page titles for adding/editing Z39.50/SRU servers In another bug we added spans to ease translations in the PROCESS block for server types. This PROCESS is used in several places, but only creates a problem when used in the title. The patch removes the spans using the remove TT filter avoiding having to change the PROCESS and causing a string change. To test: * Go to administration > Z39.50/SRU servers * Add a new Z39.50 and a SRU server or look at the form * The page title in the browser tab will show the span * Same for editing an existing Z39.50 or SRU server * Apply the patch * Verify the page titles are now correct Hint: you can see the full page title when hovering on the tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Hammat Wele <hammat@inlibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for the next release