Bug 32130

Summary: Vue files must be kept tidy
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ERMAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: david, jonathan.druart, jonathan.field, martin.renvoize, pedro.amorim
Version: unspecifiedKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
URL: https://tree.taiga.io/project/joubu-koha-erm/us/140
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 32030    
Bug Blocks: 33625    
Attachments: Bug 32130: Add a test to ensure vue files will be kept tidy
Bug 32130: Add a test to ensure vue files will be kept tidy
Bug 32130: Add a test to ensure vue files will be kept tidy
Bug 32130: Add a test to ensure vue files will be kept tidy

Description Jonathan Druart 2022-11-08 06:14:28 UTC
We want to keep them tidy, and all use the them rules.
To enforce that we should have a test in xt to catch possible discrepancies.
Comment 1 Jonathan Druart 2022-11-08 06:16:59 UTC
Created attachment 143385 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy
Comment 2 Jonathan Druart 2022-11-08 07:08:46 UTC
Created attachment 143387 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy
Comment 3 David Nind 2022-11-10 02:02:54 UTC
Created attachment 143613 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-11-10 02:03:59 UTC
Tested (using KTD) by running prove xt/vue_tidy.t

I hope that is sufficient.
Comment 5 Martin Renvoize 2022-11-11 11:22:04 UTC
Created attachment 143775 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2022-11-11 11:22:37 UTC
Makes great sense to have this.. works as desired.

Passing QA
Comment 7 Tomás Cohen Arazi 2022-11-11 12:02:58 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!