Bug 32130 - Vue files must be kept tidy
Summary: Vue files must be kept tidy
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL: https://tree.taiga.io/project/joubu-k...
Keywords: rel_22_11_candidate
Depends on: 32030
Blocks: 33625
  Show dependency treegraph
 
Reported: 2022-11-08 06:14 UTC by Jonathan Druart
Modified: 2023-12-28 20:45 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32130: Add a test to ensure vue files will be kept tidy (1.96 KB, patch)
2022-11-08 06:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32130: Add a test to ensure vue files will be kept tidy (1.96 KB, patch)
2022-11-08 07:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32130: Add a test to ensure vue files will be kept tidy (2.00 KB, patch)
2022-11-10 02:02 UTC, David Nind
Details | Diff | Splinter Review
Bug 32130: Add a test to ensure vue files will be kept tidy (2.06 KB, patch)
2022-11-11 11:22 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-08 06:14:28 UTC
We want to keep them tidy, and all use the them rules.
To enforce that we should have a test in xt to catch possible discrepancies.
Comment 1 Jonathan Druart 2022-11-08 06:16:59 UTC
Created attachment 143385 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy
Comment 2 Jonathan Druart 2022-11-08 07:08:46 UTC
Created attachment 143387 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy
Comment 3 David Nind 2022-11-10 02:02:54 UTC
Created attachment 143613 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-11-10 02:03:59 UTC
Tested (using KTD) by running prove xt/vue_tidy.t

I hope that is sufficient.
Comment 5 Martin Renvoize 2022-11-11 11:22:04 UTC
Created attachment 143775 [details] [review]
Bug 32130: Add a test to ensure vue files will be kept tidy

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2022-11-11 11:22:37 UTC
Makes great sense to have this.. works as desired.

Passing QA
Comment 7 Tomás Cohen Arazi 2022-11-11 12:02:58 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!