Bug 32161

Summary: ErmEholdingsPackagesAgreement has wrong koha_object_class
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize, pedro.amorim
Version: unspecifiedKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 32162    
Bug Blocks: 32163    
Attachments: Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Description Jonathan Druart 2022-11-10 06:36:16 UTC

    
Comment 1 Jonathan Druart 2022-11-10 06:37:47 UTC
Created attachment 143621 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however
Comment 2 Pedro Amorim 2022-11-10 17:59:20 UTC
Need to apply bug 32162 (+dbic) after applying this or else the test fails before getting to the error that this patch fixes.
More specifically, as it stands, bug 32162 fixes test 575 and this fixes test 576 when running TestBuilder.t
Comment 3 Pedro Amorim 2022-11-10 18:07:17 UTC
Created attachment 143698 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-11-11 11:13:19 UTC
Created attachment 143772 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-11-11 11:13:50 UTC
Trivial correction works as desired.. Passing QA
Comment 6 Tomás Cohen Arazi 2022-11-11 12:03:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!