Bug 32161 - ErmEholdingsPackagesAgreement has wrong koha_object_class
Summary: ErmEholdingsPackagesAgreement has wrong koha_object_class
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 32162
Blocks: 32163
  Show dependency treegraph
 
Reported: 2022-11-10 06:36 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement (1.15 KB, patch)
2022-11-10 06:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement (1.21 KB, patch)
2022-11-10 18:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement (1.27 KB, patch)
2022-11-11 11:13 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-10 06:36:16 UTC

    
Comment 1 Jonathan Druart 2022-11-10 06:37:47 UTC
Created attachment 143621 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however
Comment 2 Pedro Amorim 2022-11-10 17:59:20 UTC
Need to apply bug 32162 (+dbic) after applying this or else the test fails before getting to the error that this patch fixes.
More specifically, as it stands, bug 32162 fixes test 575 and this fixes test 576 when running TestBuilder.t
Comment 3 Pedro Amorim 2022-11-10 18:07:17 UTC
Created attachment 143698 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-11-11 11:13:19 UTC
Created attachment 143772 [details] [review]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement

Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-11-11 11:13:50 UTC
Trivial correction works as desired.. Passing QA
Comment 6 Tomás Cohen Arazi 2022-11-11 12:03:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!