Bug 32338

Summary: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted
Product: Koha Reporter: Hammat wele <hammat.wele>
Component: OPACAssignee: Hammat wele <hammat.wele>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: jacob.omara, lucas, m.de.rooy, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Attachments: OPAC - Mobile - The Selection toolbar in search result is shifted and not adjusted
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted

Description Hammat wele 2022-11-23 16:49:37 UTC Comment hidden (obsolete)
Comment 1 Hammat wele 2022-11-23 17:21:20 UTC
Created attachment 144211 [details] [review]
OPAC - Mobile - The Selection toolbar in search result is shifted and not adjusted

To reproduce:

    Go to the OPAC
    Open mobile mode
    Perform a search
    Check the top of the results table
        --> options are not displayed correctly;
        --> there is a blank space between 'Unhighlight' and 'Select All'

Apply the patch and perform the same search again.
Confirm that options are displayed correctly
Comment 2 Lucas Gass 2022-12-12 18:37:23 UTC
-Since you are changing a OPAC scss your test plan should probably mention that running 'yarn build --view opac' is required to see the changes.

-The QA tool wants your commit title to be formatted like "Bug XXXXX:"

* Commit title does not start with 'Bug XXXXX: ' - fbed8f082a1
Comment 3 Hammat wele 2022-12-14 13:10:53 UTC
Created attachment 144578 [details] [review]
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted

To reproduce:
1- Go to the OPAC
2- Inspect the webpage and switch to mobile view
3- Perform a search
4- Check the top of the results table
5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All'
6- Apply the patch
7- compile the .scss file 'yarn build --view opac'
8- Clear your navigator caches
9- repeat step 1, 2, 3, 4
10- The options are now displayed correctly
Comment 4 Lucas Gass 2022-12-15 16:05:25 UTC
Created attachment 144625 [details] [review]
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted

To reproduce:
1- Go to the OPAC
2- Inspect the webpage and switch to mobile view
3- Perform a search
4- Check the top of the results table
5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All'
6- Apply the patch
7- compile the .scss file 'yarn build --view opac'
8- Clear your navigator caches
9- repeat step 1, 2, 3, 4
10- The options are now displayed correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Marcel de Rooy 2023-02-17 10:38:20 UTC
Created attachment 146816 [details] [review]
Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted

To reproduce:
1- Go to the OPAC
2- Inspect the webpage and switch to mobile view
3- Perform a search
4- Check the top of the results table
5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All'
6- Apply the patch
7- compile the .scss file 'yarn build --view opac'
8- Clear your navigator caches
9- repeat step 1, 2, 3, 4
10- The options are now displayed correctly

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi 2023-02-22 12:08:04 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-24 11:32:54 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Jacob O'Mara 2023-02-24 11:36:06 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.