To reproduce: 1- Go to the OPAC 2- Open mobile mode 3- Perform a search 4- Check the top of the results table --> options are not displayed correctly; --> there is a blank space between "Unhighlight" and "Select All" 5- Apply the patch and perform the same search again. 6- Confirm that options are displayed correctly
Created attachment 144211 [details] [review] OPAC - Mobile - The Selection toolbar in search result is shifted and not adjusted To reproduce: Go to the OPAC Open mobile mode Perform a search Check the top of the results table --> options are not displayed correctly; --> there is a blank space between 'Unhighlight' and 'Select All' Apply the patch and perform the same search again. Confirm that options are displayed correctly
-Since you are changing a OPAC scss your test plan should probably mention that running 'yarn build --view opac' is required to see the changes. -The QA tool wants your commit title to be formatted like "Bug XXXXX:" * Commit title does not start with 'Bug XXXXX: ' - fbed8f082a1
Created attachment 144578 [details] [review] Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly
Created attachment 144625 [details] [review] Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 146816 [details] [review] Bug 32338: OPAC - Mobile - Selection toolbar in search result is shifted and not adjusted To reproduce: 1- Go to the OPAC 2- Inspect the webpage and switch to mobile view 3- Perform a search 4- Check the top of the results table 5- Notice that options are not displayed correctly, there is a blank space between 'Unhighlight' and 'Select All' 6- Apply the patch 7- compile the .scss file 'yarn build --view opac' 8- Clear your navigator caches 9- repeat step 1, 2, 3, 4 10- The options are now displayed correctly Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.