Bug 32857

Summary: Fix cataloguing/value_builder/unimarc_field_127.pl
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: CatalogingAssignee: Julian Maurice <julian.maurice>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on:    
Bug Blocks: 30975    
Attachments: Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl

Description Julian Maurice 2023-02-03 13:34:23 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:34:55 UTC
Created attachment 146122 [details] [review]
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:16:06 UTC
Created attachment 146793 [details] [review]
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-26 17:29:29 UTC
Created attachment 148725 [details] [review]
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-26 17:36:34 UTC
How I tested
~~~~~~~~~~~~

1. Add the unimarc_field_127.pl plugin to the 127$a subfield (Duration) for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. A form is displayed for entering the values for hours, minutes, and seconds.
5. This should work the same before and after the patch is applied.

Description
~~~~~~~~~~~

Without this cataloguing plugin, the duration is entered manually into the 127$a subfield (Duration). With this plugin, a form is displayed that lets you enter the values for hours, minutes, and seconds.
Comment 5 Nick Clemens (kidclamp) 2023-03-29 08:35:31 UTC
Created attachment 148874 [details] [review]
Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-03-30 10:32:19 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-11 11:12:28 UTC
Nice work everyone!

Pushed to stable for 22.11.x