This is part of the refactoring happening in bug 30975
Created attachment 146122 [details] [review] Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146793 [details] [review] Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 148725 [details] [review] Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com>
How I tested ~~~~~~~~~~~~ 1. Add the unimarc_field_127.pl plugin to the 127$a subfield (Duration) for the default UNIMARC bibliographic framework in KTD. 2. Edit a bibliographic record. 3. Select the tag editor for the subfield. 4. A form is displayed for entering the values for hours, minutes, and seconds. 5. This should work the same before and after the patch is applied. Description ~~~~~~~~~~~ Without this cataloguing plugin, the duration is entered manually into the 127$a subfield (Duration). With this plugin, a form is displayed that lets you enter the values for hours, minutes, and seconds.
Created attachment 148874 [details] [review] Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x