Bug 33051

Summary: 22600075.pl is not idempotent
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Installation and upgrade (command-line installer)Assignee: Tomás Cohen Arazi <tomascohen>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: dcook, tomascohen
Version: MainKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Bug Depends on: 31948    
Bug Blocks:    
Attachments: Bug 33051: Make 22600075.pl idempotent
Bug 33051: Make 22600075.pl idempotent

Description Tomás Cohen Arazi 2023-02-23 10:49:49 UTC
As mentioned on the bug, the atomicupdate is lacking a check for the column to exist already.
Comment 1 Katrin Fischer 2023-02-23 10:53:11 UTC
What's the best way to fix this?
Alter the atomicupdate file and backport?
Comment 2 Tomás Cohen Arazi 2023-02-23 11:00:14 UTC
Created attachment 147225 [details] [review]
Bug 33051: Make 22600075.pl idempotent

As there is no check, this dbrev could cause trouble if run twice. It
doesn't look like it is going to get backported to 22.05, but just in
case...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Marcel de Rooy 2023-02-23 12:36:27 UTC
Created attachment 147229 [details] [review]
Bug 33051: Make 22600075.pl idempotent

As there is no check, this dbrev could cause trouble if run twice. It
doesn't look like it is going to get backported to 22.05, but just in
case...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2023-02-23 22:34:35 UTC
Thx for the patch and quick QA everyone!
Comment 5 Tomás Cohen Arazi 2023-02-24 19:57:11 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2023-02-27 13:38:47 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release