Bug 33051 - 22600075.pl is not idempotent
Summary: 22600075.pl is not idempotent
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Marcel de Rooy
URL:
Keywords: rel_22_11_candidate
Depends on: 31948
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-23 10:49 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:

Attachments
Bug 33051: Make 22600075.pl idempotent (1.48 KB, patch)
2023-02-23 11:00 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 33051: Make 22600075.pl idempotent (1.57 KB, patch)
2023-02-23 12:36 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2023-02-23 10:49:49 UTC 
As mentioned on the bug, the atomicupdate is lacking a check for the column to exist already.
Comment 1 Katrin Fischer 2023-02-23 10:53:11 UTC 
What's the best way to fix this?
Alter the atomicupdate file and backport?
Comment 2 Tomás Cohen Arazi (tcohen) 2023-02-23 11:00:14 UTC 
Created attachment 147225 [details] [review]
Bug 33051: Make 22600075.pl idempotent

As there is no check, this dbrev could cause trouble if run twice. It
doesn't look like it is going to get backported to 22.05, but just in
case...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Marcel de Rooy 2023-02-23 12:36:27 UTC 
Created attachment 147229 [details] [review]
Bug 33051: Make 22600075.pl idempotent

As there is no check, this dbrev could cause trouble if run twice. It
doesn't look like it is going to get backported to 22.05, but just in
case...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2023-02-23 22:34:35 UTC 
Thx for the patch and quick QA everyone!
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-24 19:57:11 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-02-27 13:38:47 UTC 
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release