Summary: | Use template wrapper for tabs: Holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jacob.omara |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Bug Depends on: | 32571 | ||
Bug Blocks: | |||
Attachments: |
Bug 33293: Use template wrapper for tabs: Holds
Bug 33293: Use template wrapper for tabs: Holds Bug 33293: Use template wrapper for tabs: Holds |
Description
Owen Leonard
2023-03-21 16:20:28 UTC
Created attachment 148483 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Created attachment 148753 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 149320 [details] [review] Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |