Bug 33372

Summary: Use template wrapper for breadcrumbs: Circulation part 2
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: andrew.auld, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Bug Depends on: 32507    
Bug Blocks:    
Attachments: Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

Description Owen Leonard 2023-03-30 17:59:27 UTC
To continue the process started by Bug 32507, this patch will update more circulation templates so that they use the new template wrapper for breadcrumbs.

- circ/circulation.tt
- circ/curbside_pickups.tt
- circ/offline.tt
- circ/on-site_checkouts.tt
- circ/overdue.tt
- circ/pendingreserves.tt
- circ/renew.tt
Comment 1 Owen Leonard 2023-03-30 19:13:42 UTC
Created attachment 149005 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew
Comment 2 Philip Orr 2023-03-31 15:16:57 UTC
Created attachment 149040 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 3 Katrin Fischer 2023-04-08 21:09:23 UTC
Created attachment 149313 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 14:44:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:10 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.