Bug 33372 - Use template wrapper for breadcrumbs: Circulation part 2
Summary: Use template wrapper for breadcrumbs: Circulation part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-30 17:59 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2 (9.64 KB, patch)
2023-03-30 19:13 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2 (9.69 KB, patch)
2023-03-31 15:16 UTC, Philip Orr 		Details | Diff | Splinter Review
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2 (9.74 KB, patch)
2023-04-08 21:09 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-30 17:59:27 UTC 
To continue the process started by Bug 32507, this patch will update more circulation templates so that they use the new template wrapper for breadcrumbs.

- circ/circulation.tt
- circ/curbside_pickups.tt
- circ/offline.tt
- circ/on-site_checkouts.tt
- circ/overdue.tt
- circ/pendingreserves.tt
- circ/renew.tt
Comment 1 Owen Leonard 2023-03-30 19:13:42 UTC 
Created attachment 149005 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew
Comment 2 Philip Orr 2023-03-31 15:16:57 UTC 
Created attachment 149040 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 3 Katrin Fischer 2023-04-08 21:09:23 UTC 
Created attachment 149313 [details] [review]
Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation
  - Check out
    - Check out to patron
  - Curbside pickups
  - Built-in offline circulation
  - Pending on-site checkouts
  - Overdues
  - Holds to pull
  - Renew

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 14:44:38 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:38:10 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.