Bug 33733

Summary: Move t/XSLT.t to db_dependent
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Marcel de Rooy <m.de.rooy>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: david, jonathan.druart, pedro.amorim
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Attachments: Bug 33733: Remove need for Test::DBIx::Class
Bug 33733: Fix indentation in subtest
Bug 33733: Move to db_dependent
Bug 33733: Remove need for Test::DBIx::Class
Bug 33733: Fix indentation in subtest
Bug 33733: Move to db_dependent
Bug 33733: Remove need for Test::DBIx::Class
Bug 33733: Fix indentation in subtest
Bug 33733: Move to db_dependent

Description Marcel de Rooy 2023-05-15 07:01:21 UTC
This test is not database independent after all, reading various sysprefs from database.
Comment 1 Marcel de Rooy 2023-05-15 07:23:50 UTC
Created attachment 151185 [details] [review]
Bug 33733: Remove need for Test::DBIx::Class

Test plan:
Run t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-05-15 07:23:52 UTC
Created attachment 151186 [details] [review]
Bug 33733: Fix indentation in subtest

Test plan:
git diff -w HEAD~1.. t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-05-15 07:23:54 UTC
Created attachment 151187 [details] [review]
Bug 33733: Move to db_dependent

The subtest is added to the existing db_dependent test.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 David Nind 2023-05-16 02:59:11 UTC
Created attachment 151240 [details] [review]
Bug 33733: Remove need for Test::DBIx::Class

Test plan:
Run t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-05-16 02:59:13 UTC
Created attachment 151241 [details] [review]
Bug 33733: Fix indentation in subtest

Test plan:
git diff -w HEAD~1.. t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-05-16 02:59:16 UTC
Created attachment 151242 [details] [review]
Bug 33733: Move to db_dependent

The subtest is added to the existing db_dependent test.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-05-16 03:00:39 UTC
Testing notes (using KTD):

1. Ran prove t/db_dependent/XSLT.t - tests pass (no longer any t/XSLT.t).
Comment 8 Jonathan Druart 2023-05-16 10:21:48 UTC
Created attachment 151265 [details] [review]
Bug 33733: Remove need for Test::DBIx::Class

Test plan:
Run t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-05-16 10:21:50 UTC
Created attachment 151266 [details] [review]
Bug 33733: Fix indentation in subtest

Test plan:
git diff -w HEAD~1.. t/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2023-05-16 10:21:53 UTC
Created attachment 151267 [details] [review]
Bug 33733: Move to db_dependent

The subtest is added to the existing db_dependent test.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2023-05-16 10:59:35 UTC
Patches pushed for 23.05
Comment 12 Pedro Amorim 2023-06-07 10:11:56 UTC
Does not apply in 22.11.x because bug 33567 was not pushed. Not pushing.