This test is not database independent after all, reading various sysprefs from database.
Created attachment 151185 [details] [review] Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 151186 [details] [review] Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 151187 [details] [review] Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 151240 [details] [review] Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 151241 [details] [review] Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 151242 [details] [review] Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Ran prove t/db_dependent/XSLT.t - tests pass (no longer any t/XSLT.t).
Created attachment 151265 [details] [review] Bug 33733: Remove need for Test::DBIx::Class Test plan: Run t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 151266 [details] [review] Bug 33733: Fix indentation in subtest Test plan: git diff -w HEAD~1.. t/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 151267 [details] [review] Bug 33733: Move to db_dependent The subtest is added to the existing db_dependent test. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed for 23.05
Does not apply in 22.11.x because bug 33567 was not pushed. Not pushing.