Summary: | Add ability to specify fields allowed in a response | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall <kyle> |
Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
**Sponsored by** *ByWater Solutions*
|
Version(s) released in: |
23.11.00
|
Attachments: |
Bug 33926: Add ability to specify fields allowed in a response
Bug 33926: Add ability to specify fields allowed in a response Bug 33926: Add ability to specify fields allowed in a response Bug 33926: Add ability to specify fields allowed in a response |
Description
Kyle M Hall
2023-06-06 16:16:09 UTC
Created attachment 152053 [details] [review] Bug 33926: Add ability to specify fields allowed in a response At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Created attachment 152118 [details] [review] Bug 33926: Add ability to specify fields allowed in a response At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 152172 [details] [review] Bug 33926: Add ability to specify fields allowed in a response At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Sam Lau <samalau@gmail.com> I wont complain about it: WARN t/db_dependent/SIP/Message.t WARN tidiness The file is less tidy than before (bad/messy lines before: 523, now: 533) Created attachment 155377 [details] [review] Bug 33926: Add ability to specify fields allowed in a response At this time, we can specify fields to hide in SIP response at the login level. From a security perspective, it would be useful to also be able to specify which fields are allowed in a response. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Message.t Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |